Skip to content

Conversation

@tm91236
Copy link
Member

@tm91236 tm91236 commented Jan 27, 2026

Closes #859

PR Type

  • Bugfix
  • CI related changes

Description

The performance check workflow has been split into two. The original workflow now uploads the performance change comment as a workflow artefact and a new 'performance_comment' subsequently downloads this artefact and publishes a comment to the triggering PR. This should fix the problem where PRs from forked repos cannot post the performance comment to the PR.

How Has This Been Tested?

N/A

Does this PR introduce a breaking change?

No

Checklist before requesting a review

  • I have made sure that my PR is not a duplicate.
  • My code follows the style guidelines of this project.
  • I have ensured my code is easy to understand, including docstrings and comments where necessary.
  • I have performed a self-review of my code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.
  • I have updated CHANGELOG.md, if appropriate.

This was referenced Jan 27, 2026
Coverage, Performance, and Unittest workflows will now only run if
changes have been made to relevant files. Reduces wasted compute.
The performance check workflow has been split into two. The original
workflow now uploads the performance change comment as a check  and a
new 'performance_comment' subsequently downloads this check and publishes
a comment to the triggering PR. This should fix the problem where PRs
from forked repos cannot post the performance comment to the PR.

refs: #859
@tm91236 tm91236 force-pushed the ci/improve-workflows branch from 5ede96b to eb59609 Compare January 30, 2026 16:10
@tm91236 tm91236 force-pushed the ci/improve-workflows branch from eb59609 to 47f292b Compare February 2, 2026 16:08
@tm91236 tm91236 changed the title Ci/improve workflows ci: improve workflow filtering and performance workflow. Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Check performance" action fails on PRs from repository forks

2 participants