Fix unclosed ReadOnlyTransaction not detected when passed as function argument#70
Open
uji wants to merge 1 commit intogcpug:mainfrom
Open
Fix unclosed ReadOnlyTransaction not detected when passed as function argument#70uji wants to merge 1 commit intogcpug:mainfrom
uji wants to merge 1 commit intogcpug:mainfrom
Conversation
analysisutil.NotCalledIn skips transactions passed as arguments due to its internal isArg check. Add findArgPassedUnclosedTx to complement it by detecting cases where a transaction is passed to another function but Close() is never called. Fixes gcpug#49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #49
analysisutil.NotCalledIninternally skips transactions passed as function arguments (due to itsisArgcheck), causing unclosedReadOnlyTransactionto go undetected when passed to another functionfindArgPassedUnclosedTxto complementNotCalledInby specifically detecting unclosed transactions that are passed as arguments