Conversation
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
| <Label htmlFor={`${inputName}-input`}> | ||
| Other Input | ||
| </Label> | ||
| <input |
There was a problem hiding this comment.
Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.
| <Label htmlFor={`${inputName}-input`}> | ||
| {__('Other Value')} | ||
| </Label> | ||
| <input |
There was a problem hiding this comment.
Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.
|
It's looking good! I did encounter an error when trying to submit my Mobile number as an other value. Kept on receiving 400 Bad request in my console that prevented me from submitting the form. Also I was wondering if it's possible that the other value inputs are hidden and/or disabled until the other radio button is selected? I think that might clean up the form a little bit. |
| <Label htmlFor={`${inputName}-input`}> | ||
| {__('Other Value')} | ||
| </Label> | ||
| <input |
There was a problem hiding this comment.
Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.
ethanWallace
left a comment
ethanWallace
left a comment
There was a problem hiding this comment.
The mutation works great now!
I did notice when looking at the French interface some things still needed to be translated or should have a little more formatting around them.
- "Other" and "Other value" still appear in English.
- In the difference selections "GEDS" and "Directory" can be SAGE and Annuiare.
- The department section needs some translation when using the word "Department" and we can also show the French name of the departments in this section.
- The "Save" button is still in English.
- When showing the titleEn/titleFr in the opposite language, it might be worth it to add a lang attribute on the titleEn/titleFr so it can be read in the correct language.
2 participants
(WIP) Adding modal that displays differences in Directory profile data and GEDS data.