Skip to content

Conversation

qqmyers
Copy link
Member

@qqmyers qqmyers commented Apr 10, 2024

ddipdf code adapted from @lubitchv's IQSS/dataverse#10295 to be packaged as an external exporter. (The PR already uses the new exporter interface, so the main changes were to update the pom file and to use a custom UriResolver to be able to read included xsl/xml files.)

Creating a draft PR for discussion.

@lubitchv
Copy link

lubitchv commented Apr 10, 2024

Thanks Jim! One thing that I wanted to implement in pdf exporter but I did not, it is multilanguage support. The language property files are included but at the moment ddi-to-fo.xsl has select="'en'" hardcoded. I was not sure how to implement it. Maybe to create ddi-to-fo_{lang}.xsl for each language. Should it then create pdf on publication for all the languages or only for language of the dataverse (browser) in the time of publication? Maybe people would have suggestions.

@pdurbin
Copy link
Member

pdurbin commented May 1, 2024

In 58e333a I added a GitHub Action that will publish snapshots to https://s01.oss.sonatype.org/content/groups/staging/io/gdcc/export/ddi-pdf/

@pdurbin
Copy link
Member

pdurbin commented Jun 7, 2024

I now recommend a separate repo with its own GitHub Action to publish to Maven Central, like I've done at https://github.com/gdcc/exporter-croissant

@poikilotherm
Copy link
Member

poikilotherm commented Jun 20, 2024

@qqmyers @pdurbin (for the sake of completeness): please note that with #16 we will provide a common Parent POM for exporter plugins to simplify setup and releasing. Happy to receive feedback!

I also chatted with Jim and he was happy to pick up the proposal by @pdurbin to create the DDI-PDF exporter in its own repo.

@poikilotherm
Copy link
Member

Heads up that there is a milestone release of the parent POM now, so you can actually try stuff.

The example shows how to use the parent POM for now, see https://github.com/gdcc/dataverse-exporters/blob/main/example/pom.xml

Note the emptiness of that POM - in case you don't need much stuff, you might be just fine with this. It already take care about the most basic dependencies as well as build config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants