Verify multiple signature #65
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alex Ng <[email protected]>
|
Anyway of list certificates in certification chain order? |
ndbroadbent
added a commit
to DocSpring/origami-docspring
that referenced
this pull request
Mar 25, 2025
This change adds the ability to verify a PDF that is signed multiple times. Current behavior fails due to the ByteRange check during extraction of signed data. Now only the last signature in the PDF is checked for invalid ByteRange. The signatures function will extract all signatures within the PDF. Original PR: gdelugre#65 Authors: Shermane Lee, Alex Ng 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
Hi @shermanelee92, thank you for this PR! I've forked the origami library and will be actively maintaining it here: https://github.com/docspring/origami-docspring It is released on Rubygems under the name I have just merged your PR into our fork, see: DocSpring@68d0cd5 This has been released in the latest version on Rubygems: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Shermane Lee [email protected]
Co-authored-by: Alex Ng [email protected]
We added the ability to verify a PDF that is signed multiple times.
Current behaviour fails due to the ByteRange check during extracting of signed data. We changed it such that only the last signature in the PDF is checked for invalid ByteRange.
The signatures function will extract all return signatures within the PDF.