State hoist and prep for Wizard UI - #34
Merged
Merged
Conversation
maiatoday
commented
Aug 31, 2025
maiatoday
commented
Aug 31, 2025
maiatoday
commented
Aug 31, 2025
maiatoday
commented
Aug 31, 2025
maiatoday
commented
Aug 31, 2025
maiatoday
commented
Aug 31, 2025
mariobodemann
suggested changes
Sep 1, 2025
mariobodemann
left a comment
mariobodemann
left a comment
Contributor
There was a problem hiding this comment.
Some minor cleanup suggested, otherwise looks good to me.
mariobodemann
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the bitmap processing pipeline by hoisting interim output state up into the PatchableDetail Composable. This allows sub-steps to only do the part they are responsible for and allows the user to jump back to a previous points and rerun a step. Each action is also triggered by an arguably ugly
Do itbutton.These changes are necessary to get the navigation flow into a state that I can make a prettier wizard interface in a subsequent PR. This new flow also allows future changes for more interactive patchables.
Links to #33 more PRs to come