Allow SafeArea to Capture the Bitmap - #36
Merged
maiatoday merged 3 commits intoSep 7, 2025
Merged
Conversation
This change modifies the patchable composables and the `PatchableToBitmap` composable to handle bitmap capturing more directly. Refactor PatchableBoundingBox composable Refactor: Remove explicit `androidx.compose.ui.graphics.ImageBitmap` type
maiatoday
force-pushed
the
work/better-safe-area
branch
from
September 5, 2025 21:00
489e7f5 to
cec7393
Compare
maiatoday
marked this pull request as ready for review
September 5, 2025 21:02
maiatoday
commented
Sep 5, 2025
| Spacer(modifier = Modifier.weight(1f)) | ||
| } | ||
| } | ||
| TextField(value = name, onValueChange = { name = it }) |
Collaborator
Author
There was a problem hiding this comment.
This makes this particular patch interactive so you can change the name on the patch. The part that will be converted is in the SafeArea. See the screenshot
maiatoday
commented
Sep 5, 2025
| # thereby reducing the size of the R class for that library | ||
| android.nonTransitiveRClass=true No newline at end of file | ||
| android.nonTransitiveRClass=true | ||
| ksp.incremental=false |
Collaborator
Author
There was a problem hiding this comment.
this is the line that makes it always generate the PatchRegistry. Its a hack I know I know.
mariobodemann
approved these changes
Sep 6, 2025
mariobodemann
left a comment
mariobodemann
left a comment
Contributor
There was a problem hiding this comment.
Amazing, looks easier and more straight forward than I imagined!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the SafeArea capture the bitmap. So that the demo Patch Composables can have an interactive part. See AndyA Demo which has a text field to specify the text.
This requires the annotation generated code to have parameters now to trigger the bitmap creation of the safe area.
