Refactors detail view to use ViewModel - #40
Merged
Conversation
Introduces `WizardViewModel` to manage the state and logic of the `WizardScreen`. This change centralizes state management and improves the testability of the screen. Refactor WizardScreen to use ViewModel Refactor WizardScreen to use ViewModel Introduces `WizardViewModel` to manage the state and logic of the `WizardScreen`. This change centralizes state management and improves the testability of the screen.
Collaborator
Author
|
Nop it isn't groundhog day, I merged the previous PR to the wrong branch. You already reviewed it, sorry for the noise |
mariobodemann
approved these changes
Sep 7, 2025
mariobodemann
left a comment
mariobodemann
left a comment
Contributor
There was a problem hiding this comment.
Looks familiar... ;-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the detail view to utilize a WizardViewModel for managing state, improving separation of concerns and testability.
Key changes:
Introduces WizardViewModel to handle UI state, including bitmap processing, color reduction, and embroidery creation.
Updates PatchableDetail composable to use WizardViewModel and collect state using collectAsStateWithLifecycle.
Moves bitmap reduction and embroidery creation logic into the ViewModel.
Adds reset functionality to WizardViewModel to clear the state when a different patchable is selected.
Introduces PatchablePreviewMode enum to handle preview modes.