This repository has been archived by the owner on Sep 25, 2019. It is now read-only.
[WIP]: Cloud endpoints and GAE Flex support #116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to #104
Update to over 500 GDG communities world-wide
…Mongo. upgrade to latest Express and related libraries convert tasks to be triggered directly instead of via Redis+Clustering convert cron to call new tasks remove deprecated express-annotations remove API docs since they depended upon express-annotations convert rate metering to in-memory only since Redis is no longer an option temporarily disable CSRF protection Fixes #96 #80
trying to get rid of `sys` is deprecated warning, but no luck
…111!!11 update mongoose use default network since Flex doesn't seem to work on Legacy network
it relied on `express-rate` which hasn't been updated in 5 years and depends on deprecated functions in NodeJS we will use Cloud Endpoints for rate metering instead Closes #115
trying to get rid of `sys` is deprecated warning, but no luck
…111!!11 update mongoose use default network since Flex doesn't seem to work on Legacy network
…loudEndpointsAndGaeFlex Conflicts: app.yaml lib/config/express.js lib/controllers/api/index.js package.json server.js
… cloudEndpointsAndGaeFlex Conflicts: lib/controllers/api/index.js server.js
Splaktar
commented
Mar 18, 2017
| cron: | ||
| - description: daily 9am EST ingestion job | ||
| url: / | ||
| schedule: every day 13:00 |
There was a problem hiding this comment.
- update this to do ingestion jobs once OpenAPI spec is done and Cloud Endpoints are all working.
Splaktar
commented
Mar 18, 2017
| port: process.env.PORT || process.env.NODEJS_PORT || 3000, | ||
| hostname: process.env.NODEJS_IP || undefined, | ||
| port: process.env.PORT || 3000, | ||
| hostname: undefined, |
There was a problem hiding this comment.
This was key in getting GAE Flex working. If I put anything in here it would cause forwarding from the GAE proxy to Express to fail and give 503 errors.
Splaktar
commented
Mar 18, 2017
| @@ -61,6 +65,13 @@ module.exports = function (app) { | |||
| })); | |||
| } | |||
|
|
|||
| // Configure GAE proxy and health checks. Force HTTPS. | |||
| app.enable('trust proxy'); | |||
| // app.use(yesHttps({ maxAge: YES_HTTPS_MAX_AGE, includeSubdomains: true, preload: true })); | |||
There was a problem hiding this comment.
- Re-enable yes-http once HTTPS is working with hub.gdgx.io on Cloud Endpoints.
Splaktar
commented
Mar 18, 2017
| var morgan = require('morgan'); | ||
| var compression = require('compression'); | ||
| var bodyParser = require('body-parser'); | ||
| // var yesHttps = require('yes-https'); | ||
| const MongoStore = require('connect-mongo')(session); | ||
| // var csrf = require('csurf'); |
There was a problem hiding this comment.
- Re-enable CSRF protection
Splaktar
commented
Mar 18, 2017
| "https" | ||
| ], | ||
| "paths": { | ||
| "/chapters": { |
There was a problem hiding this comment.
OpenAPI Spec TODO:
- events API
- admin API
- applications API
- frisbee API
- metrics API
- tags API
- users API
- auth API
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress. Looking for help with the OpenAPI Spec description here.
Support Cloud Endpoints and GAE Flex deployment.
Enable Cloud Debug and Cloud Trace.
Support NodeJS 6.x+.
Fix deprecation warnings from NodeJS.
Add GAE Health check support.
Closes #100. Closes #99.
Relates to #85.
Fixes #80.