Skip to content

Add --verbose flag to twine upload#193

Merged
joamatab merged 1 commit into
gdsfactory:mainfrom
jackgdsf:twine-verbose-flag
Jun 12, 2026
Merged

Add --verbose flag to twine upload#193
joamatab merged 1 commit into
gdsfactory:mainfrom
jackgdsf:twine-verbose-flag

Conversation

@jackgdsf

@jackgdsf jackgdsf commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds --verbose flag to twine upload commands in the release workflow for better upload diagnostics.

Closes #192

Test plan

  • Trigger a release workflow run and verify twine outputs verbose logs.

🤖 Generated with Claude Code

Summary by Sourcery

Build:

  • Enable Twine verbose mode in the release GitHub Actions workflow to improve upload diagnostics.

Closes gdsfactory#192

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@sourcery-ai

sourcery-ai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds verbose logging to Twine uploads in the release workflow to improve diagnostics during package publication.

Flow diagram for verbose twine upload in release workflow

flowchart TD
    A[GitHub Actions release workflow] --> B[Run make build]
    B --> C[twine upload --verbose dist/*]
    C --> D[Upload package to PyPI with detailed logs]
Loading

File-Level Changes

Change Details Files
Enable verbose Twine output in the release CI workflow to aid debugging of upload issues.
  • Update the release workflow Twine upload command to include the --verbose flag so uploads emit detailed logs
.github/workflows/release.yml

Assessment against linked issues

Issue Objective Addressed Explanation
#192 Add the --verbose flag to the twine upload command in the GitHub Actions release workflow for better upload diagnostics.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@joamatab joamatab merged commit 6a8e61a into gdsfactory:main Jun 12, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add --verbose flag to twine upload in release workflow

2 participants