Metric & Imperial#398
Conversation
ge0rg
left a comment
ge0rg
left a comment
There was a problem hiding this comment.
Thanks for the PR. I've added a few comments.
| </string-array> | ||
|
|
||
| <string-array name="p_units_ev"> | ||
| <item>1</item> <item>2</item> |
There was a problem hiding this comment.
The values "1" and "2" aren't useful. You can replace them with "metric" and "imperial" or completely remove the array and use getListItemIndex() to determine the configured value.
| <string name="p_ssid_summary">Station type (1..15; 9=Mobile, 10=APRS-IS)</string> | ||
| <string name="p_ssid_entry">Enter the SSID for your station</string> | ||
| <string name="p_units_title">Distance Units</string> | ||
| <string name="p_units">Unit Preference</string> |
There was a problem hiding this comment.
This preference should go into the "Display and Notifications" section. It can be the first item in the category. Then it should be named "Distance Units" and the sub-string should be removed, as it will be replaced by the selected value anyway.
| <string name="p_ssid_entry">Enter the SSID for your station</string> | ||
| <string name="p_units_title">Distance Units</string> | ||
| <string name="p_units">Unit Preference</string> | ||
| <string name="p_units_entry">Select Distance Unit</string> |
There was a problem hiding this comment.
I've stopped adding distinct entry dialog titles, as every string needs to be translated into all languages, and the preference title ("Distance Units") can be re-used here.
| android:title="@string/p_units_title"> | ||
|
|
||
| <de.duenndns.ListPreferenceWithValue | ||
| android:key="p.units" |
There was a problem hiding this comment.
The key should be p_units for consistency with the other prefs in the main prefs screen.
2 participants
No description provided.