fix(Makefile): use native curl and tar to bypass leanSpec key download bug - #335
Open
Cyberking99 wants to merge 3 commits into
Open
fix(Makefile): use native curl and tar to bypass leanSpec key download bug#335Cyberking99 wants to merge 3 commits into
Cyberking99 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where
make test-specmysteriously fails with anAborted!error when attempting to download pre-generated XMSS test keys from GitHub.The failure stems from an upstream bug in
leanSpec's Python-based test key downloader, where an unflushed temporary file buffer causes anEOFErrorduring extraction (which theclickCLI then swallows and outputs asAborted!).To bypass this, this PR updates the
leanSpec/fixturestarget in theMakefileto:curlto securely stream the archive safely to/tmp.tarutility to reliably extract the files.-n autoto theuv run fillcommand to execute fixture generation in parallel, massively speeding up the process.Associated Issue
Closes #334
Test Plan
leanSpecworkspace.make test-spec.curlsuccessfully downloaded theprod_scheme.tar.gzandtarextracted it correctly into thetest_keysdirectory.uv run filldetected the keys, bypassed its internal download function, and successfully generated the fixtures in parallel.Checklist