GeanyLua: Fix geany.activate()

[xiota]

Resolves #1229.

[elextr]

LGBI and 👍 for fixing the doc.

[Skif-off]

Forgive my curiosity :) Why not

if (tab_idx >= 0) {
	if (tab_idx != gtk_notebook_get_current_page(NOTEBOOK)) {
		gtk_notebook_set_current_page(NOTEBOOK, tab_idx);
	}
}

?

[xiota]

I haven't looked at this in a while. Behavior originally intended is to "Actvate and focus" a document. The original inner conditional if (idx != ...) prevented both. Also, gtk_notebook_set_current_page most likely already performs necessary checks, so the additional check wastes processor cycles to produce incorrect behavior.

I had misunderstood the comment. The conditional needed to be corrected from tab_idx > 0 to tab_idx >= 0.

[xiota]

Confirmed original issue described in #1229 and this PR fixes it. Used list-open-files.lua to test.

Force pushed to rebase. Also corrected > 0 to >= 0. I had misunderstood @Skif-off's previous comment.

@b4n Should be ready for review and merge.

[Skif-off]

Any news?
In fact, the plugin is broken, because one of its functions is not working (maybe this is not the main function, but then what is the main function? :))).

[xiota]

the plugin is broken, because one of its functions is not working

Anything that needs changes to this PR?

Any news?

I'm waiting for someone to review and commit. Maybe @frlan or @elextr ?

[Skif-off]

@xiota I meant geany.activate(), this function is still broken in upstream.

I'm waiting for someone to review and commit.

Yes, I understand, I just thought that an extra reminder in notifications would remind contributors once again about the unresolved issue. And I hope I wasn't too annoying :))

[xiota]

@Skif-off No problem. Might help to have additional confirmation that this PR is working as expected. You've tested it after the rebase?

[Skif-off]

You've tested it after the rebase?

Hmm... I thought you tested it. Joke :))
I am not a contributor, so my voice has little weight, but just in case I compiled and tested it 20 minutes ago: works fime, I didn't find any problems.

[xiota]

my voice has little weight ... I didn't find any problems.

Thanks for testing. Helpful for you to have checked in case I miss something else.

After this is merged, please @ me if there is an issue or PR you'd like me to look at.

[Skif-off]

@b4n, can you add this to the 2.1.0 milestone?

I do not know when the new version of Geany is scheduled to be released, there is no alternative solution and it will be sad if all forget about this PR... :)

[xiota]

@frlan Any chance you could take a look and merge? This fixes a bug that has been affecting at least a couple users. Thanks.

[b4n]

So, the actual functional changes this is supposed to make is replace the buggy doc_idx_to_tab_idx() with document_get_notebook_page(), and returning idx >= 0 instead of idx > 0, right? The rest doesn't seem to try changing much to the logic, if I follow.

I don't know the plugin or Lua, but this looks (mostly) fine -- se review comments for the more questionable bits.

[xiota]

@b4n Thank you for reviewing. I made the suggested changes.

[b4n]

LGBI (not tested)

[b4n]

I squashed the commits, and merged this, hopefully it's been tested well enough :)
Thanks!