geanynumberedbookmarks: make the plugin work when numlock is on

[techee]

Thanks to Colomban Wendling for the patch.

A lower-risk pre-release variant of #1458.

[eht16]

LGTM though I have surprising test results:

Either I did something wrong when testing or it is like this on a German keyboard layout:

• without the patch Ctrl-Shift- does not set a bookmark at all, neither with top row number keys nor with numpad keys, regardless of numlock setting
• with the patch: Ctrl-Shift- does set bookmarks but only with top row number key, not with numpad keys, regardless of numlock setting

So, for me it is better than before but the numpad keys still don't work.

I'll try to do more testing tomorrow.

[techee]

Either I did something wrong when testing or it is like this on a German keyboard layout:

Yes, it's the German (Czech, French, etc.) keyboard.

The real full fix with international keyboard support is #1458 - it's just biggish so I wasn't sure if OK for 2.1.

[b4n]

LGTM (obviously), that's a minimal fix to get the NumLock issue sorted.

[b4n]

The real full fix with international keyboard support is #1458 - it's just biggish so I wasn't sure if OK for 2.1.

I'm not representative as I'm not an user of this plugin, and maybe it's less problematic than I'd think, but for me the current situation is bad enough that it makes sense to land a larger fix even for 2.1, especially if we can test it with en_US and en_GB as those seem to be the currently supported ones (according to code comments).

[b4n]

So, for me it is better than before but the numpad keys still don't work.

This isn't supposed to work 🙂

[techee]

LGTM (obviously), that's a minimal fix to get the NumLock issue sorted.

In fact, for me at least, it currently doesn't work at all regardless of the numlock. There's probably some other extra modifier reported by GTK with all the key presses.

[b4n]

#1458 is merged, closing this.