Skip to content

GeanyLua: update glspi_keycmd.h from the current version#1534

Merged
b4n merged 1 commit into
geany:masterfrom
Skif-off:glspi_keycmd
Jan 23, 2026
Merged

GeanyLua: update glspi_keycmd.h from the current version#1534
b4n merged 1 commit into
geany:masterfrom
Skif-off:glspi_keycmd

Conversation

@Skif-off

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread geanylua/glspi_keycmd.h Outdated
@Skif-off

Copy link
Copy Markdown
Contributor Author

@b4n, fixed, thanks.
Hm, it's a bad name because it doesn't match the style of other names, I don't know how to fix mk-keytab.lua for such cases.

@Skif-off Skif-off changed the title GeanyLua: update glspi_keycmd.h from the currentversion GeanyLua: update glspi_keycmd.h from the current version Jan 22, 2026
@b4n

b4n commented Jan 22, 2026

Copy link
Copy Markdown
Member

Hm, it's a bad name because it doesn't match the style of other names,

Hum, I see… maybe we can still change this as it hasn't been released yet.
@techee what do you have think? Any reason not to use e.g. GEANY_KEYS_VIEW_TOGGLE_MENUBAR?

@techee

techee commented Jan 22, 2026

Copy link
Copy Markdown
Member

Any reason not to use e.g. GEANY_KEYS_VIEW_TOGGLE_MENUBAR?

No reason. I think I just took xiota's patch and applied it without properly checking the naming convention. I made geany/geany#4502 fixing this.

@Skif-off

Copy link
Copy Markdown
Contributor Author

I corrected the name beforehand, so, it can be merged immediately after geany/geany#4502.

@b4n
b4n merged commit 742ec58 into geany:master Jan 23, 2026
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants