Extending markdown preview #822
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebrainz
requested changes
Mar 31, 2019
| @@ -122,7 +122,7 @@ PLUGIN_VERSION_CHECK(224) | |||
| PLUGIN_SET_TRANSLATABLE_INFO( | |||
| LOCALEDIR, | |||
| GETTEXT_PACKAGE, | |||
| _("TreeBrowser"), | |||
| _("FileTreeBrowser"),// affects the alphabetical sorting in sidebar, puts TreeBrowser just after "Documents" | |||
There was a problem hiding this comment.
This is unrelated to the pull request.
markdown/src/viewer.c
Outdated
| @@ -383,7 +389,8 @@ markdown_viewer_update_view(MarkdownViewer *self) | |||
| * substituting the file's basename for `index.html`. */ | |||
| if (DOC_VALID(doc) && doc->real_path != NULL) { | |||
| gchar *base_dir = g_path_get_dirname(doc->real_path); | |||
| base_path = g_build_filename(base_dir, "index.html", NULL); | |||
| //base_path = g_build_filename(base_dir, "index.html", NULL); | |||
There was a problem hiding this comment.
There's no need to comment out-lines, the old code can be found in Git history.
| html = g_malloc(strlen(self->priv->text->str) + 1); | ||
| strcpy(html, self->priv->text->str); html[strlen(self->priv->text->str)]='\0'; | ||
| } | ||
| else |
There was a problem hiding this comment.
Weird code formatting and indentation and stuff. Please follow the same style and formatting as the other code.
markdown/src/plugin.c
Outdated
| @@ -166,12 +166,24 @@ update_markdown_viewer(MarkdownViewer *viewer) | |||
| { | |||
| GeanyDocument *doc = document_get_current(); | |||
|
|
|||
| if (DOC_VALID(doc) && g_strcmp0(doc->file_type->name, "Markdown") == 0) { | |||
| if (DOC_VALID(doc) && g_strcmp0(doc->file_type->name, "Markdown") == 0) | |||
| { | |||
markdown/src/plugin.c
Outdated
| } | ||
| } | ||
| else | ||
| { |
There was a problem hiding this comment.
Weird formatting and indentation. Please follow the style and formatting of the other code.
| @@ -43,7 +43,7 @@ PLUGIN_SET_TRANSLATABLE_INFO(LOCALEDIR, GETTEXT_PACKAGE, | |||
| # define MARKDOWN_HELP_FILE MARKDOWN_DOC_DIR "/html/help.html" | |||
| #endif | |||
|
|
|||
| #define MARKDOWN_PREVIEW_LABEL _("Markdown Preview") | |||
| #define MARKDOWN_PREVIEW_LABEL _("Markdown") | |||
There was a problem hiding this comment.
This doesn't have anything to do with the pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With only few lines of code modification, I am now using the Mardown geany plugin as a svg image viewer (adding any other file that a Webkit supports is possible too, I only added .svg and .html). This is really handy for me; I can now write my code, run them and plot the outpouts without leaving geany IDE :-). Any interest in merging these with the upsteram branch?
A side note: I have also changed the (internal) name of Tree Browser, the previous one kept appearing after Scope plugin tabs which was not ideal