Handle documents outside workspace#69
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements support for handling documents outside the workspace in the ctags-companion extension, specifically for the provideDocumentSymbols functionality. This addresses issue #68.
Key changes:
- Updated
provideDocumentSymbolsto use absolute file paths instead of relative paths and removed the workspace-specific working directory requirement - Modified
definitionToSymbolInformationto handle cases where no workspace scope is available - Enhanced the VS Code mock to properly simulate
getWorkspaceFolderbehavior for documents outside the workspace
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/readtags.test.js | Added parameterized test cases to verify document symbols work for both documents inside and outside the workspace |
| src/readtags.js | Removed workspace-specific path handling and TODO/FIXME comments, now uses absolute paths and no longer requires a working directory |
| src/helpers.js | Updated definitionToSymbolInformation to accept undefined scope, changed default parameters from null to undefined, and added logic to handle paths when scope is not available |
| src/mocks/vscode.js | Updated getWorkspaceFolder mock to return undefined for URIs outside the workspace scope |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #68