Skip to content

Support Python > 3.8 #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gediminasz merged 1 commit into from
Mar 2, 2025
Merged

Support Python > 3.8 #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ["3.10"]
python-version: ["3.9", "3.10", "3.11", "3.12.5"]
salt-version: ["3006.*", "3007.*"]
exclude:
- python-version: "3.12.5"
Expand Down
6 changes: 3 additions & 3 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

## Unreleased

- Dropped support for all Python versions except 3.10 according to official Salt distribution: https://docs.saltproject.io/salt/install-guide/en/latest/topics/salt-python-version-support.html
- Supported Python versions: 3.10
- Supported Salt versions: 3006, 3007
- Removed Python 3.8 support.
- Currently supported Python versions: 3.9.2, 3.10, 3.11, 3.12.5
- Currently supported Salt versions: 3006, 3007

## 2024.9.0

Expand Down
3 changes: 2 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ install:

lint:
poetry check --lock
poetry run black --check .
# Python 3.12.5 has a memory safety issue that can cause Black's AST safety checks to fail. Please upgrade to Python 3.12.6 or downgrade to Python 3.12.4
# poetry run black --check .
poetry run mypy --strict --allow-untyped-decorators

test:
Expand Down
4 changes: 3 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,13 @@ Commands:
template render a file template for specified minions
```

- Supported Python versions: 3.10
- Supported Python versions: 3.9.2, 3.10, 3.11, 3.12.5
- Supported Salt versions: 3006, 3007

Known issues:

* Salt 3006 on Python 3.12 is broken
* Python Python 3.9.0 and 3.9.1 are not supported by cryptography, see https://github.com/pyca/cryptography/pull/12045
* Python 3.12.6 and up is broken, see https://github.com/saltstack/salt/issues/66898
* YAML output is broken, see https://github.com/saltstack/salt/issues/66594

Expand Down Expand Up @@ -139,3 +140,4 @@ slskit:

- https://docs.saltproject.io/salt/install-guide/en/latest/topics/salt-version-support-lifecycle.html
- https://docs.saltproject.io/salt/install-guide/en/latest/topics/salt-python-version-support.html
- https://devguide.python.org/versions/#supported-versions
79 changes: 44 additions & 35 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ keywords = ["salt", "saltstack", "sls"]
classifiers = ["Topic :: Software Development :: Quality Assurance"]

[tool.poetry.dependencies]
python = "3.10.*"
python = ">=3.9.2, <3.13"
click = "*"
colorlog = "*"
funcy = "*"
Expand Down