tests(#2406): add test_osm.py#2604
Open
bruno-portfolio wants to merge 2 commits intogee-community:masterfrom
Open
tests(#2406): add test_osm.py#2604bruno-portfolio wants to merge 2 commits intogee-community:masterfrom
bruno-portfolio wants to merge 2 commits intogee-community:masterfrom
Conversation
schwehr
requested changes
Feb 12, 2026
| def setUp(self): | ||
| mock_ox.reset_mock() | ||
|
|
||
| # ------------------------------------------------------------------ # |
Collaborator
There was a problem hiding this comment.
Remove these separator comments here and below
| import unittest | ||
| from unittest import mock | ||
|
|
||
| mock_ox = mock.MagicMock() |
Collaborator
There was a problem hiding this comment.
Add a comment explaining why this is needed.
| # osm_shp_from_address | ||
| # ------------------------------------------------------------------ # | ||
|
|
||
| @mock.patch("geemap.osm.osm_gdf_from_address") |
Collaborator
There was a problem hiding this comment.
Always use mock.patch.object when possible here and below
bruno-portfolio
force-pushed
the
tests-osm
branch
from
b8c4945 to
3a9d71c
Compare
bruno-portfolio
force-pushed
the
tests-osm
branch
from
893665d to
1815fc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds unit test coverage for the
osmmodule as requested in #2406.Follows up on @schwehr's suggestion in #2575.
Changes
OsmTestclasssys.modulesmock for osmnx (no network calls)__geo_interface__