chart: Fix various lint issues.#2679
Open
naschmitz wants to merge 1 commit intogee-community:masterfrom
Open
Conversation
schwehr
requested changes
Feb 28, 2026
| ) # pytype: disable=wrong-arg-types | ||
| if "labels" in kwargs: | ||
| raise Exception("Please remove labels in kwargs and try again.") | ||
| raise ValueError("Please remove labels in kwargs and try again.") |
Collaborator
There was a problem hiding this comment.
This is a behavior change. I'm okay with that if you are.
| def get_data( | ||
| self, x_properties: list[str] | dict[str, str] | ||
| ) -> tuple[list[Any], list[Any]]: | ||
| def get_data(self) -> tuple[list[Any], list[Any]]: |
Collaborator
There was a problem hiding this comment.
This changes the API. While it seems right to do in the long run, I think we should hold off doing that during the initial linting phase.
| """ | ||
| x_data = list(self.df[x_property]) | ||
| y_data = [self.df[x] for x in new_column_names] | ||
| def get_data(self) -> tuple[list[Any], list[Any]]: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.