Skip to content

PR resolves #11 #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

nandinib1999
Copy link

This PR resolves #11.

I have added all the files needed into run the program

Copy link
Owner

@geekquad geekquad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nandinib1999, great work.
However, please go through the Contributing Guidelines. We are accepting the implementation of the technique and not its application in a .ipython notebook. Please make the necessary changes.

@nandinib1999
Copy link
Author

Hi, okay. Will make the required changes.

@nandinib1999
Copy link
Author

Hey @geekquad,
I have updated the PR. Please see if it can be merged now. Thanks a lot! :)

Copy link
Owner

@geekquad geekquad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nandinib1999, sorry for the delay.
Please add sample input and output images in the notebook.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facial Features Detection
2 participants