Skip to content

Made architecture variable dynamic by default #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Cedric-Froehner
Copy link

Instead of having to manually assign the node_exporter_arch variable for every import of the role, the arch is now generated automatically. This is especially useful when writing a playbook for a mixed environment. (For example with arm64 RasPis and amd64 Servers.)

If the architecture detected by Ansible matches any of the following, it automatically gets translated into the correct architecture for the Node Exporter download.

Ansible detected architecture Node Exporter architecture
i368 368
x86_64 amd64
aarch64 arm64
armv7l armv7
armv6l armv6

The old default 'amd64' is now only used if the architecture detected by ansible does not match any of the above.

@Cedric-Froehner
Copy link
Author

I believe the checks are failing because of a problem with Molecule, not necessarily with my PR. But I'm not quite firm enough with Molecule to say this with a 100% confidence.

fatal: [instance]: FAILED! => {"ansible_facts": {}, "changed": false, "failed_modules": {"ansible.legacy.setup": {"ansible_facts": {"discovered_interpreter_python": "/usr/bin/python3"}, "failed": true, "msg": "ansible-core requires a minimum of Python version 3.8. Current version: 3.7.3 (default, Mar 23 2024, 16:12:05) [GCC 8.3.0]"}}, "msg": "The following modules failed to execute: ansible.legacy.setup\n"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant