Skip to content

Remove id field from "Create" models #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

graysonguarino
Copy link
Collaborator

Issue Number:
Reference the issue this PR fixes.

Description of Changes:
Provide a clear and concise explanation of what changes you made and why.

  • Specify id column as autogenerated to remove them from "Create" models.

Testing Done:
How did you test your changes? Share details like steps, tools used, or results.

Terms of contribution:

By submitting this pull request, I agree that this contribution is licensed under the terms of the Apache License, Version 2.0.


Thanks for submitting your pull request! We will review it as soon as possible.

@graysonguarino graysonguarino requested a review from ecpullen April 4, 2025 14:41
@graysonguarino
Copy link
Collaborator Author

For context, the schema specifies that the id primary key column should be auto-incremented on insert. We don't want the user to have the ability or responsibility to manually specify the primary key.

@graysonguarino graysonguarino merged commit 306f69e into mvp Apr 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants