Switch to sqlx and update protos for new schema
#24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecpullen
approved these changes
Apr 16, 2025
| DatabaseServiceState { db_conn_details } | ||
| pub fn new(db_pool: &PgPool) -> Self { | ||
| DatabaseServiceState { | ||
| db_pool: db_pool.clone(), |
There was a problem hiding this comment.
Are there any concerns with cloning this instead of keeping a reference (The answer is almost certainly no)
Collaborator
Author
There was a problem hiding this comment.
PgPool (and all *Pool types in sqlx) are wrapped in an Arc, so cloning here is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number:
Reference the issue this PR fixes.
Description of Changes:
Provide a clear and concise explanation of what changes you made and why.
dieseltosqlxTesting Done:
How did you test your changes? Share details like steps, tools used, or results.
N/A
Terms of contribution:
By submitting this pull request, I agree that this contribution is licensed under the terms of the Apache License, Version 2.0.
Thanks for submitting your pull request! We will review it as soon as possible.