Implement gRPC handlers #25
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e instead of heftier KernelSource
… Vulnerability.patch_diff
…STABLE instead of IMMUTABLE
Collaborator
|
All looks good to me. |
Collaborator
Author
Talked with @ecpullen about this PR and he thinks the queries get a bit complex and nested, thus likely a bit difficult to maintain (and I agree). Currently putting the finishing touches on some changes to the API that make the data flatter (#26). Will close this PR once I get the other one finished, but was temporarily leaving this up for comparison. |
Collaborator
Author
|
Closing in favor of #26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development still in progress. Sharing just for visibility.
Issue Number:
Reference the issue this PR fixes.
N/A
Description of Changes:
Provide a clear and concise explanation of what changes you made and why.
Testing Done:
How did you test your changes? Share details like steps, tools used, or results.
Terms of contribution:
By submitting this pull request, I agree that this contribution is licensed under the terms of the Apache License, Version 2.0.
Thanks for submitting your pull request! We will review it as soon as possible.