Update php version #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed and simplified CSL Creator test * Fixed broken Bibtex->CSL conversion test * Moved from setExpectedException() method calls to annotations
* Added BIBFORMAT.php from OSBiB * Rearranged OSBiB library files to more closely mirror the directory structure of the source library * Modified BIBFORMAT to remove all non-escape-related functionality and to tighten up how it converts (probable) ISO 8859-1 strings to UTF-8 strings * Modified BibTeX\Parser to decode LaTeX escape sequences * Fixed some documentation
* Added missing braces around lowercase "i"s.
…reviously, they would make their way into the intermediate Entry data structures from which CSL or RIS entries would be created, but neither of those formats supports explicit casing. Thus, although we lose some information this way, the resultant strings tend to look a little nicer.
* Improved opening and closing brace replacement
* Added a "Limitations" section to README.md
phpunit (a dev dependency) needs PHP 7.0, but converter itself needs only 5.3 (as required by composer.json). I've updated .travis.yml to match phpunit's requirements.
Not clear what phptal is used for in this context, so I've removed it entirely.
Merging in Travis CI fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating required PHP version and fixing broken tests.