Draft
Conversation
Now that we have the `edgedb` CLI wrapper script that handles installing the CLI if it's missing, the wrapper takes care of installing the correct version or finding the already installed binary.
We want to use the installed CLI wrapper rather than downloading a separate copy to the global cache of the package manager. Assuming the user choses to install the dependencies, running the EdgeDB initialization _after_ that should pick up the installed CLI wrapper.
This doesn't currently work because the quotes get removed when passing the arguments to the wrapper script, so we need to do some additional work in the CLI wrapper to ensure that quoted arguments like this get forwarded to the CLI properly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we have the
edgedbCLI wrapper script that handles installing the CLI if it's missing, the wrapper takes care of installing the correct version or finding the already installed binary.