Build minimal version of deps on the default rust#493
Merged
mmastrac merged 3 commits intogeldata:masterfrom Jun 9, 2025
Merged
Build minimal version of deps on the default rust#493mmastrac merged 3 commits intogeldata:masterfrom
mmastrac merged 3 commits intogeldata:masterfrom
Conversation
mmastrac
force-pushed
the
minimal_versions
branch
from
13bb6e6 to
c3e90c6
Compare
fantix
approved these changes
Jun 9, 2025
Member
There was a problem hiding this comment.
Maybe trigger a dry run of the release GH workflow to test this change?
Contributor
Author
There was a problem hiding this comment.
Yep. I tested locally and it successfully worked up until the point of change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid issues where we haven't set the minimum crate versions properly, let's run a minimal version lockfile build test on the default version of Rust. This should catch most issues.