Open
Conversation
asiebens
changed the title
jaclarke
requested changes
Jun 16, 2025
Member
jaclarke
left a comment
jaclarke
left a comment
There was a problem hiding this comment.
Thanks for the PR. It looks good, it just needs some 'version' checks so the option isn't shown when the server doesn't support it. I think updating the providerInfo here: https://github.com/geldata/gel-ui/blob/main/shared/studio/tabs/auth/state/index.tsx#L233-L245 to check if the property exists in the introspected schema data for the discord oauth type may be the best approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked with a PR on the main
gelproject.Adds a checkbox when the Discord OAuth provider is selected that ask whether the user is always shown the discord consent form or only for new users or when scopes have changed.