Drop the spaces after field names in Tuple names#8774
Open
Drop the spaces after field names in Tuple names#8774
Conversation
I used copilot to fix the tests, and it only took me about ten times longer than doing it manually. Copilot also kept wanting to suggest that it did well, when writing this commit message. One downside of this simple approach is that it will change the ids of tuple types across versions and even after a dump/restore (since the ids are associated with names in dumps). The alternate approach would be to apply a regex to fix the names up when computing displaynames.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used copilot to fix the tests, and it only took
me about ten times longer than doing it manually.
Copilot also kept wanting to suggest that it did
well, when writing this commit message.
One downside of this simple approach is that it
will change the ids of tuple types across versions
and even after a dump/restore (since the ids are
associated with names in dumps). The alternate
approach would be to apply a regex to fix the
names up when computing displaynames.