WIP: Extracting the config concerns from tenant/dbview #8948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmastrac
force-pushed
the
refactor_config
branch
from
1fa0176 to
d75b00d
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The config system is currently spread across many files, re-implemented a number of times in slightly different ways. This is a first step at refactoring where we get code out of untyped cython and move it to typed python so it can then be refactored again.
In addition, we try to avoid the zig-zagged config init between servers and tenants and pre-init: a sys_config is initialized once and passed to both tenant and server.
In a follow-up PR, we'll start to extract the config file and magic config handling as well.