Fix DATE_TRUNC with GROUP BY parameter binding#9122
Open
jackfischer wants to merge 2 commits intogeldata:masterfrom
Open
Fix DATE_TRUNC with GROUP BY parameter binding#9122jackfischer wants to merge 2 commits intogeldata:masterfrom
jackfischer wants to merge 2 commits intogeldata:masterfrom
Conversation
Two issues fixed:
1. Added 'date_trunc' and 'date_part' to funcs_with_text_args so their
text precision argument ('month', 'year', etc.) is correctly typed.
2. Fixed remap_arguments in pg_ext.pyx to use extra_blobs() instead of
variables(). The variables() method returns a deduplicated dict, but
when the same literal appears multiple times (e.g., DATE_TRUNC in both
SELECT and GROUP BY), we need all occurrences. This matches the pattern
used in args_ser.pyx.
Closes geldata#9118
jackfischer
force-pushed
the
jackfischer/9118
branch
from
b8099f9 to
d1d26c2
Compare
msullivan
approved these changes
Jan 6, 2026
... I don't have a checkout on this machine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made sure the test was real this time and actually fails and succeeds as expected.
Two issues fixed:
Added 'date_trunc' and 'date_part' to funcs_with_text_args so their text precision argument ('month', 'year', etc.) is correctly typed.
Fixed remap_arguments in pg_ext.pyx to use extra_blobs() instead of variables(). The variables() method returns a deduplicated dict, but when the same literal appears multiple times (e.g., DATE_TRUNC in both SELECT and GROUP BY), we need all occurrences. This matches the pattern used in args_ser.pyx.
Closes #9118