Conversation
scotttrinh
approved these changes
Mar 21, 2025
scotttrinh
left a comment
scotttrinh
left a comment
There was a problem hiding this comment.
I've mostly reviewed the second commit and the new deduping code, and it makes sense. If you want me to take a closer look at anything else, would you add some review comments?
mmastrac
changed the title
secret_key credentials file test
mmastrac
commented
Mar 21, 2025
| { | ||
| "fs": { | ||
| "files": { | ||
| "/home/edgedb/test/credentials.json": "{\"port\": 10702, \"user\": \"test3n\", \"secret_key\": \"nbwt_eyJhbGciOiJFUzI1NiIsInR5cCI6IkpXVCJ9.eyJlZGdlZGIuc2VydmVyLmFueV9yb2xlIjp0cnVlLCJpYXQiOjE2NjkzMTE3NjMsImlzcyI6ImxvY2FsLTEuaW50ZXJuYWwiLCJuZWJ1bGEuc2NvcGVzIjpbImFkbWluIl0sIm5lYnVsYS51c2VyX2lkIjoiM2U3ODU4YTgtNmJjNy0xMWVkLWFmNTAtMTdiMzkzMjlmZmEyIn0.9cS6-rR00fgmEmGu423IP3snJvmXe7ZGol7ZlYuHBNqmKGrWtTsMZPj-3C7dmureUmk3ZUttxioouPeAreKueg\"}" |
Contributor
Author
There was a problem hiding this comment.
@scotttrinh This is the test to take a look at -- we'd allow secret_key to be provided in the credentials file
scotttrinh
approved these changes
Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits out the credentials tests into two files. Adds a test for the credentials environment file. Adds a secret key in credentials test that none of the drivers will pass yet (needed for docker support).
Closes #44