Change the logic in the management of WebUI registration templates #10331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_reset_email(_subject).txt and use templates instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10303
After this change, the default template and those specific for Aelo or Impact installations will still be versioned with git, but the actual files used for the password reset or user creation emails will not be versioned. Therefore, when the authentication is enabled, it will be necessary to copy (and possibly modify) the desired template into the actual files during the installation. If any of the actual files does not exist, a clear error message appears when attempting to run the WebUI or to use the
createnormaluserdjango command, suggesting to create the missing file from one of the available templates.NB: without this change, in the currently exposed services, git sees modified versions of those files, so we need to stash/pull/pop whenever we need to do any update.
@vot4anto: we need to update our documentation, specifying that we need to actualize the templates after the installation.