Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] correction to indexing to get fault-to-site distance for multifault disagg by source #10428

Merged
merged 1 commit into from
Mar 8, 2025

Conversation

kejohnso
Copy link
Contributor

@kejohnso kejohnso commented Mar 7, 2025

This PR corrects an indexing error in the new functionality that divides one multifault source into many sources based on a fault mapping.
Since the tests still pass, I need to add another...

@kejohnso kejohnso requested a review from micheles March 7, 2025 21:47
@micheles micheles added this to the Engine 3.24.0 milestone Mar 8, 2025
@micheles micheles added the bug label Mar 8, 2025
@micheles
Copy link
Contributor

micheles commented Mar 8, 2025

The difficult part about adding a test is that it must run in less than 5 seconds to be accepted in calculators/tests. I have the test you gave me originally, I just need to add it to the oq-risk-test repository (see #10429).

@micheles micheles merged commit 86559ab into master Mar 8, 2025
7 checks passed
@micheles micheles deleted the fix_dist_idx_mfs branch March 8, 2025 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants