Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert some variable names to match described notation #10430

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Revert some variable names to match described notation #10430

wants to merge 2 commits into from

Conversation

raoanirudh
Copy link
Member

  • Will aid in debugging, particularly since the conditioning algorithm involves many similar variables but with different meanings, eg. prior vs posterior, calculated at station sites vs target sites etc.; ensure that the variable names match the description at the top of the file
  • Ensure comments match the code; this got rearranged in previous refactorings

@raoanirudh
Revert some variable names to match described notation
3070a50 
- Aids in debugging, particularly since the conditioning algorithm
involves many similar variables but with different meanings, eg.
prior vs posterior, calculated at station sites vs target sites etc.
- Ensure comments match the code; this got rearranged in previous
refactorings
@raoanirudh
Merge branch 'master' into cond-refact
a818588
@raoanirudh raoanirudh requested a review from micheles March 8, 2025 09:58
@micheles micheles added this to the Engine 3.24.0 milestone Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micheles micheles Awaiting requested review from micheles

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
Engine 3.24.0
Development

Successfully merging this pull request may close these issues.
2 participants
@raoanirudh @micheles