Skip to content

In engine_nightly_test.yml pass --version only if GITHUB_HEAD_REF is not empty #9065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptormene merged 2 commits into from
Oct 3, 2023
Merged

In engine_nightly_test.yml pass --version only if GITHUB_HEAD_REF is not empty #9065

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0de5d6d
In engine_nightly_test.yml pass --version only if GITHUB_HEAD_REF is …
ptormene Oct 3, 2023
2b6ed64
Remove typos
ptormene Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 30 additions & 5 deletions .github/workflows/engine_nightly_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,12 @@ jobs:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
run: |
python install.py devel --version=$GITHUB_HEAD_REF --repository=$GITHUB_REPOSITORY
if [[ "$GITHUB_HEAD_REF" != "" ]]
Copy link
Contributor

@vot4anto vot4anto Oct 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--repository is a new option available for install.py but there is no documentation about

Copy link
Member Author

@ptormene ptormene Oct 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very internal variable, used only by us to allow running tests also for PRs created in forks.

then
python install.py devel --version=$GITHUB_HEAD_REF --repository=$GITHUB_REPOSITORY
else
python install.py devel --repository=$GITHUB_REPOSITORY
fi
- name: Calculators and documentation tests
run: |
source ~/openquake/bin/activate
Expand All @@ -56,7 +61,12 @@ jobs:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
run: |
python install.py devel --version=$GITHUB_HEAD_REF --repository=$GITHUB_REPOSITORY
if [[ "$GITHUB_HEAD_REF" != "" ]]
then
python install.py devel --version=$GITHUB_HEAD_REF --repository=$GITHUB_REPOSITORY
else
python install.py devel --repository=$GITHUB_REPOSITORY
fi
- name: Hazardlib tests
run: |
source ~/openquake/bin/activate
Expand All @@ -82,7 +92,12 @@ jobs:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
run: |
python install.py devel --version=$GITHUB_HEAD_REF --repository=$GITHUB_REPOSITORY
if [[ "$GITHUB_HEAD_REF" != "" ]]
then
python install.py devel --version=$GITHUB_HEAD_REF --repository=$GITHUB_REPOSITORY
else
python install.py devel --repository=$GITHUB_REPOSITORY
fi
- name: Server 'PUBLIC' mode tests
run: |
source ~/openquake/bin/activate
Expand All @@ -107,7 +122,12 @@ jobs:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
run: |
python install.py devel --version=$GITHUB_HEAD_REF --repository=$GITHUB_REPOSITORY
if [[ "$GITHUB_HEAD_REF" != "" ]]
then
python install.py devel --version=$GITHUB_HEAD_REF --repository=$GITHUB_REPOSITORY
else
python install.py devel --repository=$GITHUB_REPOSITORY
fi
- name: Server 'READ_ONLY' mode tests
run: |
source ~/openquake/bin/activate
Expand All @@ -132,7 +152,12 @@ jobs:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
run: |
python install.py devel --version=$GITHUB_HEAD_REF --repository=$GITHUB_REPOSITORY
if [[ "$GITHUB_HEAD_REF" != "" ]]
then
python install.py devel --version=$GITHUB_HEAD_REF --repository=$GITHUB_REPOSITORY
else
python install.py devel --repository=$GITHUB_REPOSITORY
fi
- name: Server 'AELO' mode tests
run: |
source ~/openquake/bin/activate
Expand Down