Skip to content

AELO: calculate and display meanHCs_afe_RTGM plot #9072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ptormene wants to merge 18 commits into from
Closed

AELO: calculate and display meanHCs_afe_RTGM plot #9072

ptormene wants to merge 18 commits into from

Conversation

@ptormene
Copy link
Member

@ptormene ptormene commented Oct 4, 2023 •
edited
Loading

TODO:

  • fix some names
  • avoid conflicts with hmaps images management in the webui

@ptormene ptormene added this to the Engine 3.18.0 milestone Oct 4, 2023
@ptormene ptormene requested a review from micheles October 4, 2023 15:15
@ptormene ptormene self-assigned this Oct 4, 2023
micheles
micheles reviewed Oct 5, 2023
View reviewed changes
micheles
micheles reviewed Oct 5, 2023
View reviewed changes
@ptormene ptormene requested a review from kejohnso October 5, 2023 09:17
@ptormene ptormene marked this pull request as ready for review October 5, 2023 09:22
ptormene
ptormene commented Oct 5, 2023
View reviewed changes
openquake/calculators/postproc/compute_rtgm.py
img = plot_meanHCs_afe_RTGM(
imls, AFE, UHGM_RP, 1/2475, RTGM, afe_target, imt_list)
logging.info('Storing png/meanHCs_afe_RTGM')
dstore['png/meanHCs_afe_RTGM'] = img
Copy link
Member Author

@ptormene ptormene Oct 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kejohnso may you suggest a more readable name for meanHCs_afe_RTGM, please?

ptormene
ptormene commented Oct 5, 2023
View reviewed changes
openquake/server/templates/engine/get_outputs.html
{% if meanHCs_afe_RTGM %}
<div class="my-pngs">
<a href="{{ oq_engine_server_url }}/v1/calc/{{ calc_id }}/download_png/meanHCs_afe_RTGM" class="btn btn-sm">
Show meanHCs_afe_RTGM</a>
Copy link
Member Author

@ptormene ptormene Oct 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kejohnso it is especially important here, because this is the label the user will see on the button to visualize the png

@ptormene ptormene mentioned this pull request Oct 10, 2023
Closed
@ptormene
Copy link
Member Author

ptormene commented Oct 11, 2023

Superseded by #9089

@ptormene ptormene closed this Oct 11, 2023
@ptormene ptormene deleted the aelo-first-plot branch October 11, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@micheles micheles micheles left review comments

@kejohnso kejohnso Awaiting requested review from kejohnso

Assignees

@ptormene ptormene

Labels

enhancement

Projects

None yet

Milestone

Engine 3.18.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ptormene @micheles @kejohnso