Skip to content

Not losing GMFs in conditioned_gmfs scenarios with number_of_ground_motion_fields > 1 #9088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
micheles merged 6 commits into from
Oct 10, 2023
Merged

Not losing GMFs in conditioned_gmfs scenarios with number_of_ground_motion_fields > 1 #9088

micheles merged 6 commits into from
Oct 10, 2023

Conversation

@micheles
Copy link
Contributor

@micheles micheles commented Oct 10, 2023 •
edited
Loading

Part of #9003. The remaining part is avoiding to call get_conditioned_mean_and_covariance number_of_ground_motion_fields times without need.

@micheles micheles added this to the Engine 3.18.0 milestone Oct 10, 2023
@micheles micheles requested a review from raoanirudh October 10, 2023 08:55
@micheles micheles merged commit 429af0e into master Oct 10, 2023
@micheles micheles deleted the conditioned branch October 10, 2023 10:15
raoanirudh
raoanirudh reviewed Oct 11, 2023
View reviewed changes
Copy link
Member

@raoanirudh raoanirudh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raoanirudh raoanirudh raoanirudh left review comments

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

Engine 3.18.0

Development

Successfully merging this pull request may close these issues.

3 participants

@micheles @raoanirudh