Skip to content

Made the GmfComputer a bit faster #9100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
micheles merged 7 commits into from
Oct 12, 2023
Merged

Made the GmfComputer a bit faster #9100

micheles merged 7 commits into from
Oct 12, 2023

Conversation

@micheles
Copy link
Contributor

@micheles micheles commented Oct 12, 2023 •
edited
Loading

By vectorizing over the sites. Here are the numbers for SAM with 100 years on my machine (1.7x speedup):

# master vs faster
| calc_63809, maxmem=18.5 GB | time_sec | memory_mb | counts |
|----------------------------+----------+-----------+--------|
| total gen_event_based      | 1_668    | 113.4     | 131    |
| total gen_event_based      | 951.2    | 110.4     | 131    |

@micheles micheles added this to the Engine 3.18.0 milestone Oct 12, 2023
@micheles micheles requested a review from raoanirudh October 12, 2023 10:05
@micheles micheles merged commit aff4adc into master Oct 12, 2023
@micheles micheles deleted the faster branch October 12, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raoanirudh raoanirudh raoanirudh approved these changes

Assignees

No one assigned

Labels

performance

Projects

None yet

Milestone

Engine 3.18.0

Development

Successfully merging this pull request may close these issues.

3 participants

@micheles @raoanirudh