Skip to content

Conversation

@micheles
Copy link
Contributor

@micheles micheles commented Oct 14, 2023

Restored a feature that was lost in #9103. The improvement on the Chile calculation is minor in general but significant in "computing gmfs":

# now
| calc_54950, maxmem=0.5 GB | time_sec | memory_mb | counts    |
|---------------------------+----------+-----------+-----------|
| total gen_event_based     | 159_183  | 29.7      | 10_014    |
| computing mean_stds       | 66_799   | 0.0       | 1_224_412 |
| instantiating GmfComputer | 51_591   | 0.0       | 1_228_686 |
| computing gmfs            | 12_768   | 0.0       | 1_477_313 |
| updating gmfs             | 9_868    | 0.0       | 2_701_725 |
| EventBasedCalculator.run  | 1_139    | 143.7     | 1         |

# before
| calc_54946, maxmem=0.5 GB | time_sec | memory_mb | counts    |
|---------------------------+----------+-----------+-----------|
| total gen_event_based     | 165_493  | 29.2      | 10_014    |
| computing mean_stds       | 67_199   | 0.0       | 1_224_412 |
| instantiating GmfComputer | 51_612   | 0.0       | 1_228_686 |
| computing gmfs            | 19_084   | 0.0       | 3_573_951 |
| updating gmfs             | 9_921    | 0.0       | 4_798_363 |
| EventBasedCalculator.run  | 1_195    | 144.6     | 1         |

@micheles micheles added this to the Engine 3.18.0 milestone Oct 14, 2023
@micheles micheles self-assigned this Oct 14, 2023
@micheles micheles merged commit 5fb2124 into master Oct 14, 2023
@micheles micheles deleted the useless branch October 14, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants