feat: Updated generated types#32
Closed
eddie-knight wants to merge 4 commits intogemaraproj:mainfrom
Closed
Conversation
Signed-off-by: Eddie Knight <knight@linux.com>
Signed-off-by: Eddie Knight <knight@linux.com>
Signed-off-by: Eddie Knight <knight@linux.com>
jpower432
reviewed
Mar 19, 2026
|
|
||
| // UnmarshalYAML allows decoding control catalogs from older/alternate YAML schemas. | ||
| // It supports mapping `families` -> `groups`. | ||
| func (c *ControlCatalog) UnmarshalYAML(data []byte) error { |
Contributor
There was a problem hiding this comment.
Not blocking, but I have been thinking it could be useful to implement functionality to migrate between versions.
jpower432
reviewed
Mar 19, 2026
|
|
||
| // UnmarshalYAML allows decoding guidance from older/alternate YAML schemas. | ||
| // In particular, it supports using `family` instead of the struct's `group` key. | ||
| func (g *Guideline) UnmarshalYAML(data []byte) error { |
Contributor
There was a problem hiding this comment.
We have this for Guideline. I don't see one for Control.
jpower432
reviewed
Mar 19, 2026
Contributor
jpower432
left a comment
jpower432
left a comment
There was a problem hiding this comment.
Add a couple suggestions. I think it would be good to refactor the UnmarshalYAML approaches eventually to dedicate migration logic, the shadow/superset structs could be hard to maintain.
Signed-off-by: Eddie Knight <knight@linux.com>
Contributor
|
Add a PR to your branch eddie-knight#2 to update to the latest CUE module |
2 tasks
Contributor
|
@eddie-knight Should we continue with this PR or open a new one for the latest release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.