Conversation
twishabansal
added
the
do not merge
| ## Use Full Table Name Format "DATABASE_NAME.SCHEMA_NAME.TABLE_NAME" | ||
|
|
||
| **ALWAYS** use the full table name format, `DATABASE_NAME.SCHEMA_NAME.TABLE_NAME` in the generated SQL when using the `execute_sql` or `cloud_sql_postgresql__execute_sql` tool. | ||
| **ALWAYS** use the full table name format, `DATABASE_NAME.SCHEMA_NAME.TABLE_NAME` in the generated SQL when using the `execute_sql` or `cloud_sql_postgresql__execute_sql` skill. |
There was a problem hiding this comment.
nit: should we update this to be execute_sql script?
| } | ||
| }, | ||
| "contextFileName": "CLOUD-SQL-POSTGRESQL.md", | ||
| "settings": [ |
There was a problem hiding this comment.
Have you tested with the settings in the .env and having the extension load in the env vars? Does this allow the agents to use these variables without additional input from the user?
| kind: sources | ||
| name: cloud-sql-admin-source | ||
| type: cloud-sql-admin | ||
| defaultProject: twisha-dev |
There was a problem hiding this comment.
Haoyu's implementation is suppose to propagate the Env var placeholders from the prebuilt tools to here. It doesn't seem like that's working.
| "type": "string" | ||
| }, | ||
| "project": { | ||
| "default": "twisha-dev", |
There was a problem hiding this comment.
need to propagate env var here too
| ipType: public | ||
| database: inventory | ||
| user: postgres | ||
| password: TestPassword1@ |
There was a problem hiding this comment.
Can you force override this commit to remove this from the git history?
| @@ -0,0 +1,704 @@ | |||
| --- | |||
| name: cloudsql-postgres | |||
| description: skill for running tool operations in CloudSql postgres | |||
There was a problem hiding this comment.
For the first iteration, we will have to manually add the descriptions since Grouping (with the descriptions) most likely wont be complete.
| @@ -0,0 +1,12 @@ | |||
| kind: tools | |||
There was a problem hiding this comment.
We may need to update Haoyu's implementation to add the license or add that during the generation process
|
Thank you Twisha for authoring this PR! After looking at the generated config, I realized there should be some improvements done to the skill generation logic we previously introduced.
|
5 participants
Does not yet contain support for multiple sub-toolsets for cloudsql postgres