feat: client tls_options/sockopts spec, check ssl and tls #351
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just recently I tried to use this lib to send some mails through existing SMTP server and I've stumbled upon few things:
ssl
andtls
options are set. We must choose only one of them. That's why I've addedchech_ssl_optionss/2
Whenssl
is set totrue
andtls
to always I get{missing_requirement, Host, tls}
error. When I choose only one, sending succeeds.sockopts
can be[tls_client_options()]
whenssl
is set totrue
. This doesn't help very much to dialyzer, but it does to the documentation.tls_options
specified more correctly (guess that those types weren't exposed when defininggen_smtp_client:options/0
type.)