Skip to content

fix: bench mark triggers#1058

Merged
ErnestM1234 merged 1 commit intomainfrom
e/bench-fix
Feb 28, 2026
Merged

fix: bench mark triggers#1058
ErnestM1234 merged 1 commit intomainfrom
e/bench-fix

Conversation

@ErnestM1234
Copy link
Contributor

@ErnestM1234 ErnestM1234 commented Feb 28, 2026

fix benchmark behaviors

  • allow to write warnings to PRs
  • fix triggers

Greptile Summary

This PR fixes the benchmark workflow triggers by making two configuration changes: adding the pull-requests: write permission required for the benchmark action to post comments, and restricting benchmark data persistence to only occur on automated repository_dispatch events (releases). The previous logic used != 'pull_request' which also allowed manual workflow_dispatch triggers to persist data, while the new logic explicitly allows only repository_dispatch events.

Confidence Score: 5/5

  • This PR is safe to merge with no risk - it's a simple workflow configuration fix
  • The changes are minimal and well-scoped: adding a required permission and making the persistence logic more restrictive (only on releases). Both changes improve the workflow's behavior and security posture without introducing any risks
  • No files require special attention

Important Files Changed

Filename Overview
.github/workflows/benchmark.yml Added PR comment permission and restricted benchmark persistence to only automated release dispatches

Last reviewed commit: 0a121fc

@ErnestM1234 ErnestM1234 requested a review from a team as a code owner February 28, 2026 02:04
@ErnestM1234 ErnestM1234 enabled auto-merge (squash) February 28, 2026 02:06
Copy link
Contributor

@fernando-aviles fernando-aviles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ErnestM1234 ErnestM1234 merged commit 8380fec into main Feb 28, 2026
21 checks passed
@ErnestM1234 ErnestM1234 deleted the e/bench-fix branch February 28, 2026 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants