F/fix locale segment

[fernando-aviles]

Greptile Summary

This PR fixes handling of [locale] placeholders in glob patterns when used with globstar patterns like **/[locale].mdx. The previous implementation failed when the globstar matched intermediate directories because it compared path segments one-to-one, causing a mismatch in segment counts.

The fix introduces a new buildPlaceholderPathFromPattern function that:

• Uses micromatch to generate a regex from the pattern
• Leverages the RegExp indices API (ES2022 d flag) to locate where locale values appear in matched paths
• Replaces locale values back to [locale] placeholders at the correct positions

Changes include:

• Refactored locale replacement logic to use regex matching with capture group indices
• Added test case validating [locale] in filename after globstar pattern
• Added helper functions buildPlaceholderPathFromPattern, toPosixPath, and escapeRegex (unused)

Confidence Score: 4/5

• This PR is safe to merge with only minor cleanup needed
• The implementation correctly fixes the globstar pattern issue using a robust regex-based approach with the modern indices API. Test coverage validates the fix. Only minor issue is the unused escapeRegex function that should be removed.
• No files require special attention beyond removing the unused escapeRegex function

Important Files Changed

Filename	Overview
packages/cli/src/fs/config/parseFilesConfig.ts	Refactored locale placeholder replacement to use micromatch-based regex matching with indices API; includes unused escapeRegex function

Sequence Diagram

sequenceDiagram
    participant Client as expandGlobPatterns
    participant FG as fast-glob
    participant Build as buildPlaceholderPathFromPattern
    participant MM as micromatch
    participant RE as RegExp (with indices)

    Client->>Client: Replace [locale] with actual locale in pattern
    Client->>FG: sync(absolutePattern, options)
    FG-->>Client: Return matched file paths
    
    loop For each matched path
        Client->>Build: buildPlaceholderPathFromPattern(patternPath, absolutePath, "[locale]")
        Build->>Build: Convert paths to POSIX format
        Build->>MM: makeRe(posixPattern, {literalBrackets: true})
        MM-->>Build: Return base regex
        Build->>Build: Replace \\[locale\\] with ([^/]+) capture group
        Build->>RE: Create RegExp with 'd' flag for indices
        Build->>RE: exec(posixPath)
        RE-->>Build: Return match with indices array
        
        alt Match found with indices
            Build->>Build: Iterate indices in reverse order
            Build->>Build: Replace captured locale with [locale] tag
            Build->>Build: Normalize path back to OS format
            Build-->>Client: Return placeholder path
        else No match or no indices
            Build-->>Client: Return original absolute path
        end
        
        Client->>Client: Add to placeholderPaths array
    end
    
    Client-->>Client: Return {resolvedPaths, placeholderPaths}

Loading

[greptile-apps]

_{3 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}