Skip to content

feat: Allow providing a custom http.Client to the Anthropic plugin for managing HTTP requests#226

Open
pavelgj wants to merge 2 commits into
mainfrom
pj/anthropic-httpclient
Open

feat: Allow providing a custom http.Client to the Anthropic plugin for managing HTTP requests#226
pavelgj wants to merge 2 commits into
mainfrom
pj/anthropic-httpclient

Conversation

@pavelgj

@pavelgj pavelgj commented Mar 19, 2026

Copy link
Copy Markdown
Member

No description provided.

@pavelgj pavelgj requested review from CorieW and cabljac March 19, 2026 14:29
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Anthropic plugin by enabling users to supply their own http.Client instance. This change provides greater flexibility and control over how HTTP requests are made to the Anthropic API, facilitating advanced use cases like custom proxy configurations, request logging, or integrating with existing HTTP client management strategies within an application.

Highlights

  • Custom HTTP Client Support: Introduced the ability to provide a custom http.Client instance when initializing the Anthropic plugin, allowing for more control over network requests.
  • Flexible HTTP Management: Users can now manage HTTP requests with custom configurations, such as proxies, interceptors, or specific client behaviors, by passing their own http.Client.
  • Dependency Update: Added the http package as a dependency to facilitate the new http.Client functionality.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the ability to provide a custom http.Client to the Anthropic plugin. This is a valuable feature for users who need to customize HTTP request behavior, reuse clients for efficiency, or mock HTTP interactions for testing. The implementation is well-executed, correctly passing the custom client through the necessary layers. Crucially, the changes correctly handle the lifecycle of the http.Client, ensuring that user-provided clients are not closed by the plugin. The logic to conditionally close internally created clients, both for the main plugin instance and for temporary request-specific instances, is sound. The necessary dependency on the http package has also been added. Overall, the changes are correct and well-implemented.

@pavelgj pavelgj requested a review from kevmoo April 29, 2026 12:49
String? apiKey,
Map<String, String>? headers,
String? baseUrl,
http.Client? httpClient,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Document the new param? Also be clear that it will be closed w/ the plugin??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants