chore: updated build-gen script configs to properly cover all packages#250
Open
pavelgj wants to merge 2 commits into
Open
chore: updated build-gen script configs to properly cover all packages#250pavelgj wants to merge 2 commits into
pavelgj wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the Melos workspace configuration in pubspec.yaml by updating build scripts to use the exec property with packageFilters and adding a dedicated apply_license task. The changes also expand the package scopes for several build commands. The review feedback suggests standardizing the use of packageFilters across all scripts, ensuring sequential execution with concurrency: 1 for core packages, and restoring or adding dependsOn filters to prevent script failures in packages that do not utilize build_runner.
- Refactored build-gen-core to use native exec and packageFilters instead of a nested melos exec command, and set concurrency to 1 to prevent race conditions during core generation. - Removed invalid curly braces from scope definitions in build-gen-plugins and build-gen-testapps. - Added dependsOn: "build_runner" to plugin and testapp scripts to ensure they only run on packages that actually require code generation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.