feat(genkit_google_genai): add video generation support with Veo#262
Draft
CorieW wants to merge 7 commits into
Draft
feat(genkit_google_genai): add video generation support with Veo#262CorieW wants to merge 7 commits into
CorieW wants to merge 7 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for video generation using the Veo model within the genkit_google_genai package. Key changes include the implementation of a new Veo model handler that manages long-running operations and polling, the addition of VeoOptions for configuring generation parameters such as aspect ratio and duration, and updates to the API client to support asynchronous predictions. Review feedback suggests adding a timeout to media download requests to prevent indefinite hanging and highlights potential memory concerns when base64-encoding large video files into data URIs.
CorieW
changed the title
…ad timeout for video handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds video generation support to the
googleaiplugin and Veo models.Testing