feat(vertexai): add support for mistral models#265
Draft
CorieW wants to merge 7 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for Mistral models within the Vertex AI plugin. Key changes include the implementation of a Mistral-specific API client, request/response mapping logic, and configuration options (MistralOptions). The VertexAiPluginImpl was updated to dynamically list and resolve Mistral models from the mistralai publisher, and a new helper was added to parse publisher model names. Additionally, unit tests were included to verify the correct endpoint construction and model discovery. I have no feedback to provide.
cabljac
reviewed
May 18, 2026
cabljac
reviewed
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for Mistral models in VertexAI plugin.
Testing
Note: Supports more params now than in the screenshots.